From 944a9de08a00f8273e73cd28b40e46cc0eb0bad1 Mon Sep 17 00:00:00 2001 From: Vasil Dimov Date: Fri, 15 Jul 2022 13:49:17 +0200 Subject: net: remove CNetAddr::ToString() and use ToStringAddr() instead Both methods do the same thing, so simplify to having just one. Further, `CService` inherits `CNetAddr` and `CService::ToString()` overrides `CNetAddr::ToString()` but the latter is not virtual which may be confusing. Avoid such a confusion by not having non-virtual methods with the same names in inheritance. --- src/test/fuzz/netaddress.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'src/test/fuzz/netaddress.cpp') diff --git a/src/test/fuzz/netaddress.cpp b/src/test/fuzz/netaddress.cpp index d71bbcf812..3d7d3188a1 100644 --- a/src/test/fuzz/netaddress.cpp +++ b/src/test/fuzz/netaddress.cpp @@ -70,7 +70,6 @@ FUZZ_TARGET(netaddress) assert(net_addr.GetNetwork() == Network::NET_ONION); } (void)net_addr.IsValid(); - (void)net_addr.ToString(); (void)net_addr.ToStringAddr(); const CSubNet sub_net{net_addr, fuzzed_data_provider.ConsumeIntegral()}; -- cgit v1.2.3