From 27e70f1f5be1f536f2314cd2ea42b4f80d927fbd Mon Sep 17 00:00:00 2001 From: Ava Chow Date: Thu, 25 Jan 2024 16:27:08 -0500 Subject: consensus: Store transaction nVersion as uint32_t Given that the use of a transaction's nVersion is always as an unsigned int, it doesn't make sense to store it as signed and then cast it to unsigned. --- src/script/interpreter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/script/interpreter.cpp') diff --git a/src/script/interpreter.cpp b/src/script/interpreter.cpp index c969ce45f1..1ebf5425a5 100644 --- a/src/script/interpreter.cpp +++ b/src/script/interpreter.cpp @@ -1743,7 +1743,7 @@ bool GenericTransactionSignatureChecker::CheckSequence(const CScriptNum& nSeq // Fail if the transaction's version number is not set high // enough to trigger BIP 68 rules. - if (static_cast(txTo->nVersion) < 2) + if (txTo->nVersion < 2) return false; // Sequence numbers with their most significant bit set are not -- cgit v1.2.3