From 58a9601dffa6d9b3b881a476169458787d382919 Mon Sep 17 00:00:00 2001 From: fanquake Date: Mon, 20 Jun 2022 11:43:21 +0100 Subject: build: globally define NOMINMAX Define (and document) `NOMINMAX` once, rather than across multiple source files. Defining this prevents the definition of min/max macros when using mingw-w64, which may conflict with unprefixed std::min/max usage. While that might not be the case for us, we'd always prefer to use the standard library in any case. For example: https://github.com/mingw-w64/mingw-w64/blob/73cadc06c62c6af5faf76f64ef08e684b48de48c/mingw-w64-headers/include/ntdef.h#L289-L300 --- src/qt/guiutil.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/qt/guiutil.cpp') diff --git a/src/qt/guiutil.cpp b/src/qt/guiutil.cpp index e3c6d8a624..186ed4f644 100644 --- a/src/qt/guiutil.cpp +++ b/src/qt/guiutil.cpp @@ -24,9 +24,6 @@ #include #ifdef WIN32 -#ifndef NOMINMAX -#define NOMINMAX -#endif #include #include #include -- cgit v1.2.3