From 407175e0c2bc797599ebd9c0a1f2ec89ad7af136 Mon Sep 17 00:00:00 2001 From: Jon Atack Date: Tue, 28 Jul 2020 10:47:07 +0200 Subject: p2p: change CInv::type from int to uint32_t fixes issue #19678 UBSan implicit-integer-sign-change Credit to Eugene (Crypt-iQ) for finding and reporting the issue and to Vasil Dimov (vasild) for the original suggestion --- src/protocol.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/protocol.h') diff --git a/src/protocol.h b/src/protocol.h index 2e6c767cdd..415922dfb6 100644 --- a/src/protocol.h +++ b/src/protocol.h @@ -408,7 +408,7 @@ class CInv { public: CInv(); - CInv(int typeIn, const uint256& hashIn); + CInv(uint32_t typeIn, const uint256& hashIn); SERIALIZE_METHODS(CInv, obj) { READWRITE(obj.type, obj.hash); } @@ -425,7 +425,7 @@ public: // Combined-message helper methods bool IsGenTxMsg() const { return type == MSG_TX || type == MSG_WTX || type == MSG_WITNESS_TX; } - int type; + uint32_t type; uint256 hash; }; -- cgit v1.2.3