From b301950df32443e358bc22ca22c6f9ac09d18219 Mon Sep 17 00:00:00 2001 From: lucash-dev Date: Sun, 9 Dec 2018 22:04:07 -0800 Subject: Made expicit constructor CTransaction(const CMutableTransaction &tx). This makes the above constructor explicit. The rationale is that this conversion has very significant performance effects. Making it explicit makes it easier to reason about these performance trade-offs, and helps identify possible functions that need a CMutableTransaction version. --- src/primitives/transaction.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/primitives') diff --git a/src/primitives/transaction.h b/src/primitives/transaction.h index c88d5b1ad3..f6f8e31363 100644 --- a/src/primitives/transaction.h +++ b/src/primitives/transaction.h @@ -298,7 +298,7 @@ public: CTransaction(); /** Convert a CMutableTransaction into a CTransaction. */ - CTransaction(const CMutableTransaction &tx); + explicit CTransaction(const CMutableTransaction &tx); CTransaction(CMutableTransaction &&tx); template -- cgit v1.2.3