From af1d2ff88344e1545ac8d9ad09f8e37e264da712 Mon Sep 17 00:00:00 2001
From: dergoegge <n.goeggi@gmail.com>
Date: Wed, 1 Nov 2023 14:04:44 +0000
Subject: [primitives] Precompute result of CTransaction::HasWitness

---
 src/primitives/transaction.h | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

(limited to 'src/primitives/transaction.h')

diff --git a/src/primitives/transaction.h b/src/primitives/transaction.h
index 89deb9de4d..594168bbcc 100644
--- a/src/primitives/transaction.h
+++ b/src/primitives/transaction.h
@@ -310,12 +310,15 @@ public:
 
 private:
     /** Memory only. */
+    const bool m_has_witness;
     const Txid hash;
     const Wtxid m_witness_hash;
 
     Txid ComputeHash() const;
     Wtxid ComputeWitnessHash() const;
 
+    bool ComputeHasWitness() const;
+
 public:
     /** Convert a CMutableTransaction into a CTransaction. */
     explicit CTransaction(const CMutableTransaction& tx);
@@ -365,15 +368,7 @@ public:
 
     std::string ToString() const;
 
-    bool HasWitness() const
-    {
-        for (size_t i = 0; i < vin.size(); i++) {
-            if (!vin[i].scriptWitness.IsNull()) {
-                return true;
-            }
-        }
-        return false;
-    }
+    bool HasWitness() const { return m_has_witness; }
 };
 
 /** A mutable version of CTransaction. */
-- 
cgit v1.2.3