From 3f033f01a6b0f7772ae1b21044903b8f4249ad08 Mon Sep 17 00:00:00 2001 From: glozow Date: Tue, 27 Jul 2021 15:55:25 +0100 Subject: MOVEONLY: check for disjoint conflicts and ancestors to policy/rbf This checks that a transaction isn't trying to replace something it supposedly depends on. --- src/policy/rbf.h | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'src/policy/rbf.h') diff --git a/src/policy/rbf.h b/src/policy/rbf.h index 0f9a3d9856..6c4e218959 100644 --- a/src/policy/rbf.h +++ b/src/policy/rbf.h @@ -56,4 +56,17 @@ std::optional GetEntriesForConflicts(const CTransaction& tx, CTxMem std::optional HasNoNewUnconfirmed(const CTransaction& tx, const CTxMemPool& m_pool, const CTxMemPool::setEntries& setIterConflicting) EXCLUSIVE_LOCKS_REQUIRED(m_pool.cs); + +/** Check the intersection between two sets of transactions (a set of mempool entries and a set of + * txids) to make sure they are disjoint. + * @param[in] setAncestors Set of mempool entries corresponding to ancestors of the + * replacement transactions. + * @param[in] setConflicts Set of txids corresponding to the mempool conflicts + * (candidates to be replaced). + * @param[in] txid Transaction ID, included in the error message if violation occurs. + * @returns error message if the sets intersect, std::nullopt if they are disjoint. + */ +std::optional EntriesAndTxidsDisjoint(const CTxMemPool::setEntries& setAncestors, + const std::set& setConflicts, + const uint256& txid); #endif // BITCOIN_POLICY_RBF_H -- cgit v1.2.3