From 94d2cc35be98d3b20db88b2a3745322e5b0aa9d4 Mon Sep 17 00:00:00 2001 From: John Newbery Date: Fri, 11 Dec 2020 10:35:32 +0000 Subject: [net processing] Remove unnecesary nNewHeight variable in UpdatedBlockTip() --- src/net_processing.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/net_processing.cpp') diff --git a/src/net_processing.cpp b/src/net_processing.cpp index 6e9d8119ab..acacb7c592 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -1293,8 +1293,7 @@ void PeerManager::NewPoWValidBlock(const CBlockIndex *pindex, const std::shared_ * in ::ChainActive() to our peers. */ void PeerManager::UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockIndex *pindexFork, bool fInitialDownload) { - const int nNewHeight = pindexNew->nHeight; - m_connman.SetBestHeight(nNewHeight); + m_connman.SetBestHeight(pindexNew->nHeight); SetServiceFlagsIBDCache(!fInitialDownload); // Relay inventory, but don't relay old inventory during initial block download. @@ -1311,7 +1310,7 @@ void PeerManager::UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockInde break; } } - m_connman.ForEachNode([nNewHeight, &vHashes](CNode* pnode) { + m_connman.ForEachNode([&vHashes](CNode* pnode) { LOCK(pnode->cs_inventory); for (const uint256& hash : reverse_iterate(vHashes)) { pnode->vBlockHashesToAnnounce.push_back(hash); -- cgit v1.2.3