From cc61bc2e19b1c8cb32778ef42746d32b02cc2671 Mon Sep 17 00:00:00 2001 From: fanquake Date: Fri, 27 May 2022 15:54:21 +0100 Subject: compat: remove glibcxx sanity checks These checks were added in #4339, (see also #4081), to test our back-compat stubs, however, those stubs no-longer exist (#22930), meaning that these checks are now just testing some specific standard library behaviour, without a particular rationale, or reason, compared to any other standard library functions we use. There has also been some discussion about the sanity checks in the context of the libbitcoinkernel refactoring, see https://github.com/bitcoin/bitcoin/pull/25065#discussion_r880668218. Removing the checks removes the need to worry about atleast the glibcxx checks. Also remove the list of check from the doc in init.h, because it is incomplete, and anyone who wants to know what checks are included can look at the function. --- src/init/common.cpp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/init') diff --git a/src/init/common.cpp b/src/init/common.cpp index eac6732968..788abb9821 100644 --- a/src/init/common.cpp +++ b/src/init/common.cpp @@ -7,7 +7,6 @@ #endif #include -#include #include #include #include @@ -49,9 +48,6 @@ bool SanityChecks() return InitError(Untranslated("Elliptic curve cryptography sanity check failure. Aborting.")); } - if (!glibcxx_sanity_test()) - return false; - if (!Random_SanityCheck()) { return InitError(Untranslated("OS cryptographic RNG sanity check failure. Aborting.")); } -- cgit v1.2.3