From 46709c5f27bf6cbc8eba1298b04bd079da2cdded Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Tue, 18 Jan 2022 19:18:02 +0200
Subject: refactor: Get rid of `BanMan::SetBannedSetDirty()`

---
 src/banman.cpp | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

(limited to 'src/banman.cpp')

diff --git a/src/banman.cpp b/src/banman.cpp
index 50dc0750e1..5b2a179543 100644
--- a/src/banman.cpp
+++ b/src/banman.cpp
@@ -55,12 +55,13 @@ void BanMan::DumpBanlist()
         SweepBanned();
         if (!m_is_dirty) return;
         banmap = m_banned;
-        SetBannedSetDirty(false);
+        m_is_dirty = false;
     }
 
     int64_t n_start = GetTimeMillis();
     if (!m_ban_db.Write(banmap)) {
-        SetBannedSetDirty(true);
+        LOCK(m_cs_banned);
+        m_is_dirty = true;
     }
 
     LogPrint(BCLog::NET, "Flushed %d banned node addresses/subnets to disk  %dms\n", banmap.size(),
@@ -202,9 +203,3 @@ void BanMan::SweepBanned()
         m_client_interface->BannedListChanged();
     }
 }
-
-void BanMan::SetBannedSetDirty(bool dirty)
-{
-    LOCK(m_cs_banned); //reuse m_banned lock for the m_is_dirty flag
-    m_is_dirty = dirty;
-}
-- 
cgit v1.2.3