From 9ad6746ccd6dc31141fd0144686b641e31bf626b Mon Sep 17 00:00:00 2001 From: practicalswift Date: Thu, 1 Jun 2017 16:13:35 +0200 Subject: Use static_cast instead of C-style casts for non-fundamental types A C-style cast is equivalent to try casting in the following order: 1. const_cast(...) 2. static_cast(...) 3. const_cast(static_cast(...)) 4. reinterpret_cast(...) 5. const_cast(reinterpret_cast(...)) By using static_cast(...) explicitly we avoid the possibility of an unintentional and dangerous reinterpret_cast. Furthermore static_cast(...) allows for easier grepping of casts. --- src/addrman.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/addrman.h') diff --git a/src/addrman.h b/src/addrman.h index 18f3062287..2775b13b27 100644 --- a/src/addrman.h +++ b/src/addrman.h @@ -59,7 +59,7 @@ public: template inline void SerializationOp(Stream& s, Operation ser_action) { - READWRITE(*(CAddress*)this); + READWRITE(*static_cast(this)); READWRITE(source); READWRITE(nLastSuccess); READWRITE(nAttempts); -- cgit v1.2.3