From ed0498af2827ccf033c9a7c4f46b82424e411083 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Barbosa?= Date: Wed, 27 Mar 2019 17:00:06 +0000 Subject: interfaces: Add Chain::requestMempoolTransactions Github-Pull: #15652 Rebased-From: 57908a739ca377d60ef224ce0f565d4412a414f4 --- src/interfaces/chain.cpp | 8 ++++++++ src/interfaces/chain.h | 13 +++++++++++++ 2 files changed, 21 insertions(+) diff --git a/src/interfaces/chain.cpp b/src/interfaces/chain.cpp index da810bc5e6..d3d9e86e8d 100644 --- a/src/interfaces/chain.cpp +++ b/src/interfaces/chain.cpp @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -177,6 +178,13 @@ public: LOCK(cs_main); return GuessVerificationProgress(Params().TxData(), LookupBlockIndex(block_hash)); } + void requestMempoolTransactions(std::function fn) override + { + LOCK2(::cs_main, ::mempool.cs); + for (const CTxMemPoolEntry& entry : ::mempool.mapTx) { + fn(entry.GetSharedTx()); + } + } }; } // namespace diff --git a/src/interfaces/chain.h b/src/interfaces/chain.h index 3a54b9164e..57e9703758 100644 --- a/src/interfaces/chain.h +++ b/src/interfaces/chain.h @@ -16,6 +16,9 @@ class CBlock; class CScheduler; class uint256; struct CBlockLocator; +class CTransaction; + +using CTransactionRef = std::shared_ptr; namespace interfaces { @@ -127,6 +130,16 @@ public: //! Estimate fraction of total transactions verified if blocks up to //! the specified block hash are verified. virtual double guessVerificationProgress(const uint256& block_hash) = 0; + + //! Synchronously send TransactionAddedToMempool notifications about all + //! current mempool transactions to the specified handler and return after + //! the last one is sent. These notifications aren't coordinated with async + //! notifications sent by handleNotifications, so out of date async + //! notifications from handleNotifications can arrive during and after + //! synchronous notifications from requestMempoolTransactions. Clients need + //! to be prepared to handle this by ignoring notifications about unknown + //! removed transactions and already added new transactions. + virtual void requestMempoolTransactions(std::function fn) = 0; }; //! Interface to let node manage chain clients (wallets, or maybe tools for -- cgit v1.2.3