From e23def8fcc4558b1a49ee8f2dd608fe91ced1d6d Mon Sep 17 00:00:00 2001 From: dergoegge Date: Thu, 20 Oct 2022 17:55:44 +0100 Subject: [net processing] Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started --- src/net_processing.cpp | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/net_processing.cpp b/src/net_processing.cpp index 1c44ec9903..a6299be403 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -2559,14 +2559,22 @@ bool PeerManagerImpl::TryLowWorkHeadersSync(Peer& peer, CNode& pfrom, const CBlo // Now a HeadersSyncState object for tracking this synchronization is created, // process the headers using it as normal. - return IsContinuationOfLowWorkHeadersSync(peer, pfrom, headers); + if (!IsContinuationOfLowWorkHeadersSync(peer, pfrom, headers)) { + // Something went wrong, reset the headers sync. + peer.m_headers_sync.reset(nullptr); + LOCK(m_headers_presync_mutex); + m_headers_presync_stats.erase(peer.m_id); + } } else { LogPrint(BCLog::NET, "Ignoring low-work chain (height=%u) from peer=%d\n", chain_start_header->nHeight + headers.size(), pfrom.GetId()); - // Since this is a low-work headers chain, no further processing is required. - headers = {}; - return true; } + + // The peer has not yet given us a chain that meets our work threshold, + // so we want to prevent further processing of the headers in any case. + headers = {}; + return true; } + return false; } -- cgit v1.2.3