From 1bf4a62cb61bd4b91d9cd4e379fea2b914786342 Mon Sep 17 00:00:00 2001 From: Andrew Chow Date: Thu, 6 May 2021 14:12:13 -0400 Subject: scripted-diff: rename some variables actual_target -> selection_target nChange -> change_and_fee -BEGIN VERIFY SCRIPT- sed -i -e 's/actual_target/selection_target/g' src/wallet/coinselection.cpp sed -i -e '2801,3691s/nChange /change_and_fee /g' src/wallet/wallet.cpp sed -i -e '2801,3691s/nChange,/change_and_fee,/g' src/wallet/wallet.cpp sed -i -e '2801,3691s/nChange;/change_and_fee;/g' src/wallet/wallet.cpp -END VERIFY SCRIPT- --- src/wallet/coinselection.cpp | 14 +++++++------- src/wallet/wallet.cpp | 10 +++++----- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/wallet/coinselection.cpp b/src/wallet/coinselection.cpp index 5a18308a73..2228536f29 100644 --- a/src/wallet/coinselection.cpp +++ b/src/wallet/coinselection.cpp @@ -70,7 +70,7 @@ bool SelectCoinsBnB(std::vector& utxo_pool, const CAmount& target_v std::vector curr_selection; // select the utxo at this index curr_selection.reserve(utxo_pool.size()); - CAmount actual_target = not_input_fees + target_value; + CAmount selection_target = not_input_fees + target_value; // Calculate curr_available_value CAmount curr_available_value = 0; @@ -79,7 +79,7 @@ bool SelectCoinsBnB(std::vector& utxo_pool, const CAmount& target_v assert(utxo.effective_value > 0); curr_available_value += utxo.effective_value; } - if (curr_available_value < actual_target) { + if (curr_available_value < selection_target) { return false; } @@ -94,12 +94,12 @@ bool SelectCoinsBnB(std::vector& utxo_pool, const CAmount& target_v for (size_t i = 0; i < TOTAL_TRIES; ++i) { // Conditions for starting a backtrack bool backtrack = false; - if (curr_value + curr_available_value < actual_target || // Cannot possibly reach target with the amount remaining in the curr_available_value. - curr_value > actual_target + cost_of_change || // Selected value is out of range, go back and try other branch + if (curr_value + curr_available_value < selection_target || // Cannot possibly reach target with the amount remaining in the curr_available_value. + curr_value > selection_target + cost_of_change || // Selected value is out of range, go back and try other branch (curr_waste > best_waste && (utxo_pool.at(0).fee - utxo_pool.at(0).long_term_fee) > 0)) { // Don't select things which we know will be more wasteful if the waste is increasing backtrack = true; - } else if (curr_value >= actual_target) { // Selected value is within range - curr_waste += (curr_value - actual_target); // This is the excess value which is added to the waste for the below comparison + } else if (curr_value >= selection_target) { // Selected value is within range + curr_waste += (curr_value - selection_target); // This is the excess value which is added to the waste for the below comparison // Adding another UTXO after this check could bring the waste down if the long term fee is higher than the current fee. // However we are not going to explore that because this optimization for the waste is only done when we have hit our target // value. Adding any more UTXOs will be just burning the UTXO; it will go entirely to fees. Thus we aren't going to @@ -112,7 +112,7 @@ bool SelectCoinsBnB(std::vector& utxo_pool, const CAmount& target_v break; } } - curr_waste -= (curr_value - actual_target); // Remove the excess value as we will be selecting different coins now + curr_waste -= (curr_value - selection_target); // Remove the excess value as we will be selecting different coins now backtrack = true; } diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp index 456c26ea31..35805bc4c9 100644 --- a/src/wallet/wallet.cpp +++ b/src/wallet/wallet.cpp @@ -2990,19 +2990,19 @@ bool CWallet::CreateTransactionInternal( bnb_used = false; } - const CAmount nChange = nValueIn - nValueToSelect; - if (nChange > 0) + const CAmount change_and_fee = nValueIn - nValueToSelect; + if (change_and_fee > 0) { // Fill a vout to ourself - CTxOut newTxOut(nChange, scriptChange); + CTxOut newTxOut(change_and_fee, scriptChange); // Never create dust outputs; if we would, just // add the dust to the fee. - // The nChange when BnB is used is always going to go to fees. + // The change_and_fee when BnB is used is always going to go to fees. if (IsDust(newTxOut, coin_selection_params.m_discard_feerate) || bnb_used) { nChangePosInOut = -1; - nFeeRet += nChange; + nFeeRet += change_and_fee; } else { -- cgit v1.2.3