Age | Commit message (Collapse) | Author |
|
8b9adca Allow `-noserver` with bitcoind (Wladimir J. van der Laan)
|
|
This fixes linking issues when statically linking
(thanks @imwuzhh).
|
|
|
|
Another problem detected by cs_wallet lock detection (#3401).
|
|
|
|
These don't aquire the wallet lock internally, so the caller has to do
it.
|
|
duplicate check in AddressTableModel::setData accesses
wallet data structure as well as SetAddressBook without proper LOCK, fix this.
|
|
012ca1c LoadWallet: acquire cs_wallet mutex before clearing setKeyPool (Wladimir J. van der Laan)
9569168 Document cs_wallet lock and add AssertLockHeld (Wladimir J. van der Laan)
19a5676 Use mutex pointer instead of name for AssertLockHeld (Wladimir J. van der Laan)
|
|
daa6b20 Unittests for uint256.h (Thomas Holenstein)
e85e19b Changed Get64(.) to GetLow64() (Thomas Holenstein)
|
|
aec55a0 "getnetworkhashps" with defaults was yielding "0", the hashrate is not 0. (Gregory Maxwell)
|
|
340bff3 ui: Better tab order in send coins entry (Wladimir J. van der Laan)
|
|
|
|
Pressing <tab> after entering a label now brings the focus to the
address entry, instead of the row of buttons. In my experience this
is more useful, as I usually want to paste an address after
entering the label.
The buttons are mostly useless anyway:
- Choosing a previously used address should be discouraged
- When I'm already using the keyboard the 'paste address' button is
useless - just use the Ctrl-V. Maybe it would be an idea to remove it
completely
- I usually don't want to remove the entry I'm typing now! So makes
sense to have it at the end of the tab chain.
|
|
This was broken in 4c6d41b8b653ef90639b1a32f6aab0bb1cef90c5.
|
|
Unit tests for uint256.h. The file uint160_tests.cpp is no longer
needed. The ad-hoc tests which were in uint256.h are also no longer
needed. The new tests achieve 100% coverage.
|
|
The function Get64(.) has a bug in case the width is not divisible by 64.
Since it is only ever used as Get64(0) this simply changes it to this
special case. Additionally, an assert is added, and a cast to prevent
a compiler error.
|
|
96e5f61 extend std::exception logging in txdb.cpp (Philip Kaufmann)
|
|
d78f35a Explicitly ensure that wallet is unlocked in `importprivkey` (Wladimir J. van der Laan)
|
|
1ad2636 qt: Prevent non-functional GUI from popping up during Init (Wladimir J. van der Laan)
|
|
This makes for a more useful error reply (fixes #957).
|
|
|
|
3380713 [Qt] coin control change address handling update (Philip Kaufmann)
|
|
Allow running bitcoind without server.
- Default to -server mode (of course) for bitcoind with SoftSetBoolArg
- Remove fForceServer argument from AppInit2
- Move fDaemon to a static variable in bitcoind
|
|
- re-work change address handling so that default is CNoDestination(),
until a verified and known change address was entered (easier code flow)
- add a missing NULL pointer check for adresstablemodel
- add a missing text when opening coin control address selection for
priority and ensure the label is black
- add a missing . at the end of a sentence
|
|
|
|
9e9056c Remove -logtodebugger (Wladimir J. van der Laan)
|
|
6027b46 Add rpc command 'getunconfirmedbalance' to obtain total unconfirmed balance (Michael Bauer)
|
|
2ea980a qt: Treat regtest as testnet (Wladimir J. van der Laan)
|
|
No need to do anything special in the GUI for regtest mode,
but do treat it at testnet not mainnet to prevent confusion.
|
|
Due to walletframe changes, the overview page button is no longer
automatically selected at startup even though the overview page is shown.
|
|
Moved includes of "db.h" into #ifdef ENABLE_WALLET blocks or remove
them.
|
|
c3a7f51 Move `verifymessage` from rpcwallet to rpcmisc (Wladimir J. van der Laan)
723a03d Move `createmultisig` from rpcwallet to rpcmisc (Wladimir J. van der Laan)
452955f Move `validateaddress` from rpcwallet to rpcmisc (Wladimir J. van der Laan)
cd7fa8b Move `nTransactionFee` from main.cpp to wallet.cpp (Wladimir J. van der Laan)
a943bde Move `settxfee` from rpcblockchain to rpcwallet (Wladimir J. van der Laan)
16bc9aa Move `getinfo` from rpcnet to rpcmisc (Wladimir J. van der Laan)
652e156 add new RPC implementation file `rpcmisc.cpp` (Wladimir J. van der Laan)
|
|
Make the function mutex-aware, to prevent having to lock cs_wallet
at the call site in Init.
|
|
Add locking assertions to wallet to all methods that
access internal fields and do not aquire the cs_wallet mutex.
|
|
This makes it useable for non-global locks such as the wallet and
keystore locks.
|
|
Missed these in ca2c83d (#3415).
|
|
6c1bf19 [Qt] style-police, add missing license headers (Philip Kaufmann)
|
|
4a61c39 qt: status WalletModel::Aborted is no longer used (Wladimir J. van der Laan)
ca2c83d Remove unused ThreadSafeAskFee from ui_interface (Wladimir J. van der Laan)
37e67d3 Remove unused ThreadSafeHandleURI from ui_interface (Wladimir J. van der Laan)
|
|
06eb2f2 Seperate out wallet options in help message (Wladimir J. van der Laan)
|
|
7df07b3 [Qt] fix RecentRequestsTableModel function ambiuguity (Philip Kaufmann)
|
|
55c6890 Squashed 'src/leveldb/' changes from 936b461..e991315 (Pieter Wuille)
|
|
- add missing license headers in Mac files
- small code formating cleanups
|
|
|
|
When a InitError or InitWarning happens, the
GUI pops up but is unusable (until Init finishes).
This is caused by showNormalIfMinimized. Add a message
flag to skip this call for Init errors or warnings.
|
|
|
|
22f0135 Rebrand to `Bitcoin Core` (Wladimir J. van der Laan)
|
|
Seperate out the wallet options in HelpMessage, and
don't show them if compiled with --disable-wallet.
Also add documentation for `-disablewallet` option.
|
|
Aborting transactions happens in the GUI now as it should,
not the backend.
|
|
0205abd Improve unit test code not to compare with explanatory messages for each platform. Instead, use have an exception object to check if the string returned by what() on the raised exception matches the string returned by what() on the expected exception instance. This way, we do not need to list all different possible explanatory strings for different platforms in the test code, and make it simple. (The idea is by Cory Fields.) (Kangmo)
|
|
platform.
Instead, use have an exception object to check if the string returned by what() on the raised exception matches the string returned by what() on the expected exception instance.
This way, we do not need to list all different possible explanatory strings for different platforms in the test code, and make it simple. (The idea is by Cory Fields.)
|