diff options
| author | Andrew Chow <github@achow101.com> | 2023-02-20 17:45:32 -0500 |
|---|---|---|
| committer | Andrew Chow <github@achow101.com> | 2023-04-11 15:55:31 -0400 |
| commit | e83babe3b85b22e2360a99f9827b2b0d107ad0fa (patch) | |
| tree | 67baf57399f7b1c386c64317164a0360976d1451 /test | |
| parent | 2f8000513675467e62bee9d0f836d2fefcc479af (diff) | |
wallet: Replace use of purpose strings with an enum
Instead of storing and passing around fixed strings for the purpose of
an address, use an enum.
This also rationalizes the CAddressBookData struct, documenting all fields and
making them public, and simplifying the representation to avoid bugs like
https://github.com/bitcoin/bitcoin/pull/26761#discussion_r1134615114 and make
it not possible to invalid address data like change addresses with labels.
Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/wallet_labels.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/test/functional/wallet_labels.py b/test/functional/wallet_labels.py index a39700f73a..f074339a2b 100755 --- a/test/functional/wallet_labels.py +++ b/test/functional/wallet_labels.py @@ -71,6 +71,10 @@ class WalletLabelsTest(BitcoinTestFramework): node = self.nodes[0] assert_equal(len(node.listunspent()), 0) + self.log.info("Checking listlabels' invalid parameters") + assert_raises_rpc_error(-8, "Invalid 'purpose' argument, must be a known purpose string, typically 'send', or 'receive'.", node.listlabels, "notavalidpurpose") + assert_raises_rpc_error(-8, "Invalid 'purpose' argument, must be a known purpose string, typically 'send', or 'receive'.", node.listlabels, "unknown") + # Note each time we call generate, all generated coins go into # the same address, so we call twice to get two addresses w/50 each self.generatetoaddress(node, nblocks=1, address=node.getnewaddress(label='coinbase')) |