diff options
author | MarcoFalke <falke.marco@gmail.com> | 2019-12-09 13:52:38 -0500 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2019-12-09 13:52:47 -0500 |
commit | df2b7437596965a5f4008630c1cc08b6a3756924 (patch) | |
tree | 2062f6412845dd2f5056fe559eda87af6f148dbe /src | |
parent | 03e781ff4fd7844692dd4891db6f7322db5d593a (diff) | |
parent | 5ac804a9eb0cdbdcff8b50ecfb736f8793cab805 (diff) | |
download | bitcoin-df2b7437596965a5f4008630c1cc08b6a3756924.tar.xz |
Merge #17675: tests: Enable tests which are incorrectly skipped when running test_runner.py --usecli
5ac804a9eb0cdbdcff8b50ecfb736f8793cab805 tests: Use a default of supports_cli=True (instead of supports_cli=False) (practicalswift)
993e38a4e2fa66093314b988dfbe459f46aa5864 tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such (practicalswift)
Pull request description:
Annotate functional tests supporting `bitcoin-cli` (`--usecli`) as such.
Prior to this commit 74 tests were unnecessarily skipped when running `test_runner.py --usecli`.
Before:
```
$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
grep -E ' (Passed|Skipped) *$' | sort | uniq -c
9 ✓ Passed
126 ○ Skipped
```
After:
```
$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
grep -E ' (Passed|Skipped) *$' | sort | uniq -c
83 ✓ Passed
52 ○ Skipped
```
Context: `--usecli` was introduced in https://github.com/bitcoin/bitcoin/pull/11970/commits/f6ade9ce1a679a026c84e5baa9f8595fa2be78a5
ACKs for top commit:
laanwj:
Code review ACK 5ac804a9eb0cdbdcff8b50ecfb736f8793cab805
Tree-SHA512: 249c0b691a74cf201c729df86c3db2b3faefa53b94703941e566943d252c6d14924e935a8da4f592951574235923fbb7cd22612a5e7e02ff6c762c55a2320ca3
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions