aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorpracticalswift <practicalswift@users.noreply.github.com>2018-12-14 14:50:21 +0100
committerpracticalswift <practicalswift@users.noreply.github.com>2019-06-26 16:57:14 +0200
commitc4606b84329d760d7cee144bebe05807857edaae (patch)
treeb8abcff8c3b042e2782fc4b0bd6d2f3c68385a13 /src
parent332c6134bb15384e5b91c631e821fe52a591d3bc (diff)
downloadbitcoin-c4606b84329d760d7cee144bebe05807857edaae.tar.xz
Add Travis check for single parameter constructors not marked "explicit"
Diffstat (limited to 'src')
-rw-r--r--src/index/blockfilterindex.cpp4
-rw-r--r--src/interfaces/chain.cpp2
-rw-r--r--src/rpc/util.h2
3 files changed, 4 insertions, 4 deletions
diff --git a/src/index/blockfilterindex.cpp b/src/index/blockfilterindex.cpp
index 20f33baf2c..c3ce8d7af0 100644
--- a/src/index/blockfilterindex.cpp
+++ b/src/index/blockfilterindex.cpp
@@ -53,7 +53,7 @@ struct DBHeightKey {
int height;
DBHeightKey() : height(0) {}
- DBHeightKey(int height_in) : height(height_in) {}
+ explicit DBHeightKey(int height_in) : height(height_in) {}
template<typename Stream>
void Serialize(Stream& s) const
@@ -76,7 +76,7 @@ struct DBHeightKey {
struct DBHashKey {
uint256 hash;
- DBHashKey(const uint256& hash_in) : hash(hash_in) {}
+ explicit DBHashKey(const uint256& hash_in) : hash(hash_in) {}
ADD_SERIALIZE_METHODS;
diff --git a/src/interfaces/chain.cpp b/src/interfaces/chain.cpp
index 161dd01ffe..02f39cef8e 100644
--- a/src/interfaces/chain.cpp
+++ b/src/interfaces/chain.cpp
@@ -205,7 +205,7 @@ public:
class RpcHandlerImpl : public Handler
{
public:
- RpcHandlerImpl(const CRPCCommand& command) : m_command(command), m_wrapped_command(&command)
+ explicit RpcHandlerImpl(const CRPCCommand& command) : m_command(command), m_wrapped_command(&command)
{
m_command.actor = [this](const JSONRPCRequest& request, UniValue& result, bool last_handler) {
if (!m_wrapped_command) return false;
diff --git a/src/rpc/util.h b/src/rpc/util.h
index 0eb2fef5c3..457c3a2e8f 100644
--- a/src/rpc/util.h
+++ b/src/rpc/util.h
@@ -221,7 +221,7 @@ struct RPCResults {
struct RPCExamples {
const std::string m_examples;
- RPCExamples(
+ explicit RPCExamples(
std::string examples)
: m_examples(std::move(examples))
{