diff options
| author | Andrew Chow <github@achow101.com> | 2023-01-04 12:35:32 -0500 |
|---|---|---|
| committer | Andrew Chow <github@achow101.com> | 2023-01-04 12:41:47 -0500 |
| commit | a27324148089d86cf8cc51ba552338544b8c9b43 (patch) | |
| tree | 6e37ec27e083dae7d6e143fac30931ec22ddb5af /src/wallet/wallet.h | |
| parent | 139ba2bf121c1d496a0ecfedb3b5f263b944cc85 (diff) | |
| parent | b942c94d153f83b77ef5d603211252d9abadde95 (diff) | |
Merge bitcoin/bitcoin#26020: test: Change coinselection parameter location to make tests independent
b942c94d153f83b77ef5d603211252d9abadde95 test: Change coinselection parameter location to make tests independent (yancy)
Pull request description:
the `subtract_fee_outputs` param is expected to be `true` for all subsequent tests. It should be defined outside of a single test so that if it's removed or changed, all subsequent tests won't fail. Currently if you remove this [test](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L304:L325) the following [test](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L327:L345) fails. This change makes the tests independent.
ACKs for top commit:
achow101:
ACK b942c94d153f83b77ef5d603211252d9abadde95
aureleoules:
ACK b942c94d153f83b77ef5d603211252d9abadde95.
rajarshimaitra:
tACK b942c94d153f83b77ef5d603211252d9abadde95
theStack:
ACK b942c94d153f83b77ef5d603211252d9abadde95
Tree-SHA512: 461e19d15351318102ef9f96c68442365d8ca238c48ad7aefe23e8532b33b91dadf6c7840c7894574bccede6da162a55ad7a6f6a330d61a11ce804e68ddc5e9c
Diffstat (limited to 'src/wallet/wallet.h')
0 files changed, 0 insertions, 0 deletions