diff options
| author | Andrew Chow <github@achow101.com> | 2023-10-04 13:14:57 -0400 |
|---|---|---|
| committer | Andrew Chow <github@achow101.com> | 2023-10-04 13:32:40 -0400 |
| commit | cc68a3b9ddbcbb6d29b67bb92cfe8aac53d4b417 (patch) | |
| tree | bd944c29c82d99f9c5c5f9f8e2dfe41cca5a72f4 /.github | |
| parent | 3cd02806ecd2edd08236ede554f1685866625757 (diff) | |
| parent | 7e4003226030a04a19c718a4b1b83b4ca40ca33f (diff) | |
Merge bitcoin/bitcoin#28589: test: assumeutxo func test race fixes
7e4003226030a04a19c718a4b1b83b4ca40ca33f tests: assumeutxo: accept final height from either chainstate (James O'Beirne)
5bd2010f024b5bcccf1d57bae6fc36c53f5facc5 test: assumeutxo: avoid race in functional test (James O'Beirne)
7005a01c19001ab5821731597656f8bc5e8c11e3 test: add wait_for_connect to BitcoinTestFramework.connect_nodes (James O'Beirne)
Pull request description:
Fixes https://github.com/bitcoin/bitcoin/issues/28585.
Fixes a few races within the assumeutxo tests:
- In general, `-stopatheight` can't be used with `connect_nodes` safely because the latter performs blocking assertions that are racy with the stopatheight triggering.
- Now that the snapshot chainstate is listed as `normal` after background validation, accept the final height from either chainstate.
ACKs for top commit:
MarcoFalke:
lgtm ACK 7e4003226030a04a19c718a4b1b83b4ca40ca33f
fjahr:
Code review ACK 7e4003226030a04a19c718a4b1b83b4ca40ca33f
achow101:
ACK 7e4003226030a04a19c718a4b1b83b4ca40ca33f
ryanofsky:
Code review ACK 7e4003226030a04a19c718a4b1b83b4ca40ca33f
Tree-SHA512: 8cbd2a0ca8643f94baa0ae3561dcf68c3519d5ba851c6049e1768f28cae6434f47ffc28d404bf38ed11030ce3f00aae0a8be3f6d563e6ae6680d83c928a173d8
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions