From dc034af961132a3593fb2d4f81ddb06c67c2b6d2 Mon Sep 17 00:00:00 2001
From: Sjors Provoost <sjors@sprovoost.nl>
Date: Fri, 30 Apr 2021 13:13:15 +0200
Subject: bip174: link to 'compact size' definition

---
 bip-0174.mediawiki | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'bip-0174.mediawiki')

diff --git a/bip-0174.mediawiki b/bip-0174.mediawiki
index 295a9a3..8ef525c 100644
--- a/bip-0174.mediawiki
+++ b/bip-0174.mediawiki
@@ -65,7 +65,7 @@ be used as a separator and allow for easier unserializer implementation.</ref>.
 Where:
 
 ;<tt><keytype></tt>
-: A compact size unsigned integer representing the type. This compact size unsigned integer must be minimally encoded, i.e. if the value can be represented using one byte, it must be represented as one byte. There can be multiple entries with the same <tt><keytype></tt> within a specific <tt><map></tt>, but the <tt><key></tt> must be unique.
+: A [https://en.bitcoin.it/wiki/Protocol_documentation#Variable_length_integer compact size] unsigned integer representing the type. This compact size unsigned integer must be minimally encoded, i.e. if the value can be represented using one byte, it must be represented as one byte. There can be multiple entries with the same <tt><keytype></tt> within a specific <tt><map></tt>, but the <tt><key></tt> must be unique.
 ;<tt><keylen></tt>
 : The compact size unsigned integer containing the combined length of <tt><keytype></tt> and <tt><keydata></tt>
 ;<tt><valuelen></tt>
@@ -420,7 +420,7 @@ The currently defined per-input types are defined as follows:
 | Taproot Key Spend Signature
 | <tt>PSBT_IN_TAP_KEY_SIG = 0x13</tt>
 | None
-| No key data 
+| No key data
 | <tt><signature></tt>
 | The 64 or 65 byte Schnorr signature for key path spending a Taproot output. Finalizers should remove this field after <tt>PSBT_IN_FINAL_SCRIPTWITNESS</tt> is constructed.
 |
-- 
cgit v1.2.3


From 6366f8ebcbab1bc5e59325bf8a00ed96065bd671 Mon Sep 17 00:00:00 2001
From: Sjors Provoost <sjors@sprovoost.nl>
Date: Wed, 12 Jan 2022 16:37:01 +0100
Subject: bip174: document PSBT 0 handling of type > 0xFD

---
 bip-0174.mediawiki | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'bip-0174.mediawiki')

diff --git a/bip-0174.mediawiki b/bip-0174.mediawiki
index 8ef525c..874af14 100644
--- a/bip-0174.mediawiki
+++ b/bip-0174.mediawiki
@@ -819,6 +819,9 @@ If an updater is updating a PSBT and needs to add a field that is only available
 New fields should first be proposed on the bitcoin-dev mailing list.
 If a field requires significant description as to its usage, it should be accompanied by a separate BIP.
 The field must be added to the field listing tables in the Specification section.
+Although some PSBT version 0 implementations encode types as uint8_t rather than compact size,
+it is still safe to add >0xFD fields to PSBT 0, because these old parsers ignore
+unknown fields, and <keytype> is prefixed by its length. 
 
 ===Procedure For New Versions===
 
-- 
cgit v1.2.3

