From 7be25f9fb20631c8c62d268c7f25ebe564a7a8e6 Mon Sep 17 00:00:00 2001 From: Ava Chow Date: Wed, 24 Apr 2024 19:06:23 -0400 Subject: ci: Fetch depth 2 for diffchecks --- .github/workflows/github-action-checks.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/github-action-checks.yml b/.github/workflows/github-action-checks.yml index bfc014b..0b723e1 100644 --- a/.github/workflows/github-action-checks.yml +++ b/.github/workflows/github-action-checks.yml @@ -16,4 +16,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 + with: + fetch-depth: 2 - run: scripts/diffcheck.sh -- cgit v1.2.3 From eb9007c8690436ea4a60189ab32e36686007e32c Mon Sep 17 00:00:00 2001 From: Ava Chow Date: Wed, 24 Apr 2024 19:13:48 -0400 Subject: diffchecks.sh: Build table first --- scripts/diffcheck.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/diffcheck.sh b/scripts/diffcheck.sh index 4e4c459..3d8a9e5 100755 --- a/scripts/diffcheck.sh +++ b/scripts/diffcheck.sh @@ -1,5 +1,6 @@ #!/bin/bash +scripts/buildtable.pl >/tmp/table.mediawiki 2> /dev/null diff README.mediawiki /tmp/table.mediawiki | grep '^[<>] |' >/tmp/after.diff || true if git checkout HEAD^ && scripts/buildtable.pl >/tmp/table.mediawiki 2>/dev/null; then diff README.mediawiki /tmp/table.mediawiki | grep '^[<>] |' >/tmp/before.diff || true -- cgit v1.2.3 From 98f000a6fb330ec8afa87bcb6ba0cad20c7552f2 Mon Sep 17 00:00:00 2001 From: Ava Chow Date: Wed, 24 Apr 2024 19:11:06 -0400 Subject: diffchecks.sh: Make success clear and exit with failure on error --- scripts/diffcheck.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/diffcheck.sh b/scripts/diffcheck.sh index 3d8a9e5..aa9f557 100755 --- a/scripts/diffcheck.sh +++ b/scripts/diffcheck.sh @@ -9,6 +9,8 @@ if git checkout HEAD^ && scripts/buildtable.pl >/tmp/table.mediawiki 2>/dev/null echo "$newdiff" exit 1 fi + echo "README table matches expected table from BIP files" else echo 'Cannot build previous commit table for comparison' + exit 1 fi -- cgit v1.2.3 From 94ca14f34eaa776411365eb87c1f5e32b453b8c2 Mon Sep 17 00:00:00 2001 From: Ava Chow Date: Wed, 24 Apr 2024 19:14:34 -0400 Subject: ci: Use actions/checkout@v4 v3 is deprecated --- .github/workflows/github-action-checks.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/github-action-checks.yml b/.github/workflows/github-action-checks.yml index 0b723e1..b18267e 100644 --- a/.github/workflows/github-action-checks.yml +++ b/.github/workflows/github-action-checks.yml @@ -5,17 +5,17 @@ jobs: Link-Format-Checks: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: scripts/link-format-chk.sh Build-Table-Checks: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: scripts/buildtable.pl >/tmp/table.mediawiki || exit 1 Diff-Checks: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: fetch-depth: 2 - run: scripts/diffcheck.sh -- cgit v1.2.3 From 09439bb6626305c0bf146069cf8ea467d05b87c5 Mon Sep 17 00:00:00 2001 From: Ava Chow Date: Wed, 24 Apr 2024 19:16:30 -0400 Subject: ci: Clarify that diffchecks fails until a number is assigned --- .github/workflows/github-action-checks.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/github-action-checks.yml b/.github/workflows/github-action-checks.yml index b18267e..8a7d2ac 100644 --- a/.github/workflows/github-action-checks.yml +++ b/.github/workflows/github-action-checks.yml @@ -13,6 +13,7 @@ jobs: - uses: actions/checkout@v4 - run: scripts/buildtable.pl >/tmp/table.mediawiki || exit 1 Diff-Checks: + name: "Diff Checks (fails until number assignment)" runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 -- cgit v1.2.3